Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-603: Add lvms tag to volume groups #447

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

suleymanakbas91
Copy link
Contributor

This PR adds an lvms tag to the volume groups used by LVMS. Also, this implements a temporary logic to add the tag to the existing volume groups, which is useful especially for upgrades.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2023

@suleymanakbas91: This pull request references OCPVE-603 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR adds an lvms tag to the volume groups used by LVMS. Also, this implements a temporary logic to add the tag to the existing volume groups, which is useful especially for upgrades.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2023
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2023
@openshift-ci openshift-ci bot requested review from jerpeter1 and qJkee October 10, 2023 11:22
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #447 (acc6dad) into main (441ca07) will decrease coverage by 0.30%.
The diff coverage is 18.18%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   59.41%   59.12%   -0.30%     
==========================================
  Files          21       21              
  Lines        1614     1622       +8     
==========================================
  Hits          959      959              
- Misses        539      547       +8     
  Partials      116      116              
Files Coverage Δ
internal/controllers/vgmanager/lvm/lvm.go 41.71% <18.18%> (-2.00%) ⬇️

Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor questions and missing test, other than that lgtm :)

cmd/vgmanager/vgmanager.go Outdated Show resolved Hide resolved
cmd/vgmanager/vgmanager.go Outdated Show resolved Hide resolved
cmd/vgmanager/vgmanager.go Outdated Show resolved Hide resolved
@suleymanakbas91 suleymanakbas91 force-pushed the tag-existing-vgs branch 3 times, most recently from 6985e92 to 4aad88c Compare October 10, 2023 14:10
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@suleymanakbas91
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 63c12a5 into openshift:main Oct 10, 2023
@suleymanakbas91 suleymanakbas91 deleted the tag-existing-vgs branch October 10, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants